-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Result object now gives a detailed error message upon trying to call … #42
Merged
YHordijk
merged 11 commits into
main
from
clarify-behaviour-and-error-messages-for-resultsresult-objects
Oct 19, 2023
Merged
Result object now gives a detailed error message upon trying to call … #42
YHordijk
merged 11 commits into
main
from
clarify-behaviour-and-error-messages-for-resultsresult-objects
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or hash an empty Result object
… dict. To fix this we have to make our own items method where we skip keys that are of the special format
…ng __contains__. This is because __contains__ is now also checking if the key is empty
…shown in the original dict __str__ function. To print hidden keys, please use the __repr__ method.
Updating testing workflow
SiebeLeDe
reviewed
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that call() is compatible only with python versions > 3.10 I believe
YHordijk
deleted the
clarify-behaviour-and-error-messages-for-resultsresult-objects
branch
October 19, 2023 13:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…or hash an empty Result object