Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20 adding vibration mode analysis #40

Merged
merged 22 commits into from
Oct 24, 2023
Merged

20 adding vibration mode analysis #40

merged 22 commits into from
Oct 24, 2023

Conversation

ksalimans
Copy link
Collaborator

Transition state validation using vibrations

@ksalimans ksalimans linked an issue Oct 12, 2023 that may be closed by this pull request
adding vibration mode analysis #20
Closed
@ksalimans ksalimans requested a review from YHordijk October 12, 2023 13:02
YHordijk
YHordijk reviewed Oct 12, 2023
View reviewed changes
TCutility/results/adf.py Outdated Show resolved Hide resolved
SiebeLeDe
SiebeLeDe reviewed Oct 12, 2023
View reviewed changes
TCutility/results/ams.py Outdated Show resolved Hide resolved
TCutility/results/adf.py Show resolved Hide resolved
TCutility/analysis/ts_vibration.py Show resolved Hide resolved
YHordijk
YHordijk requested changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@YHordijk YHordijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change the feedback, I think it is ready to be added to TCutility

@YHordijk YHordijk added enhancement New feature or request new release This merge is slated to be a new release labels Oct 12, 2023
@ksalimans ksalimans requested a review from YHordijk October 19, 2023 11:53
@ksalimans ksalimans requested a review from SiebeLeDe October 20, 2023 15:50
SiebeLeDe
SiebeLeDe reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@SiebeLeDe SiebeLeDe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

The documentation is clear and I understand what the code tries to achieve without going into the details
Nice checks if a section is present so that the user knows what's going on
Also good addition of tests

@SiebeLeDe SiebeLeDe merged commit bd80c24 into main Oct 24, 2023
6 checks passed
@SiebeLeDe SiebeLeDe deleted the 20-adding-vibration-mode-analysis branch October 24, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiebeLeDe SiebeLeDe SiebeLeDe left review comments

@YHordijk YHordijk YHordijk approved these changes

Assignees

@ksalimans ksalimans

Labels
enhancement New feature or request new release This merge is slated to be a new release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adding vibration mode analysis
3 participants
@ksalimans @YHordijk @SiebeLeDe