Added results reading function for CRESTJob
#320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiebeLeDe
reviewed
Oct 11, 2024
There was a problem hiding this comment.
For the large if/else block, it is clearer to use a mapping dict instead so that you don't get a huge block if you want to change more things. It can also help with performance since not all checks have to be done each time for checking the if/else statment.
See this video (mistake 3) for an example
Parity with main
SiebeLeDe
had a problem deploying
to
github-pages
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are now able to read results from
CRESTJobcalculations. This means we now have rerun prevention for these jobs as well, which is good as they are often quite expensive to run.