Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a missing settings object for DFTBJob #241

Merged
merged 1 commit into from
May 28, 2024
Merged

Added a missing settings object for DFTBJob #241

merged 1 commit into from
May 28, 2024

Conversation

YHordijk
Copy link
Contributor

No description provided.

@YHordijk YHordijk self-assigned this May 22, 2024
@YHordijk YHordijk linked an issue May 22, 2024 that may be closed by this pull request
Missing settings attribute for DFTBJob #240
Closed
@YHordijk YHordijk requested a review from SiebeLeDe May 22, 2024 16:25
@YHordijk YHordijk marked this pull request as ready for review May 22, 2024 16:26
SiebeLeDe
SiebeLeDe reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@SiebeLeDe SiebeLeDe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, how was this possible in the first place actually? I thought the AMSJob already contains a self.settings attribute?

@YHordijk
Copy link
Contributor Author

We removed that at some point, due to job inheritance

@YHordijk YHordijk merged commit 7e3fea1 into main May 28, 2024
6 checks passed
@YHordijk YHordijk deleted the 240-missing-settings-attribute-for-dftbjob branch May 28, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiebeLeDe SiebeLeDe SiebeLeDe approved these changes

Assignees

@YHordijk YHordijk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing settings attribute for DFTBJob
2 participants
@YHordijk @SiebeLeDe