183 add job inheriting #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ictionary to a Result object
…ild settings for a new job
Closed
|
Looks good. I am wondering does it copy the whole class? So not only the functional, basis set etc. but also dependancies or post/preamples? This could increase the risk of human errors for larger workflows (forgetting to get rid of certain dependancies) |
SiebeLeDe
reviewed
Mar 29, 2024
|
Indeed, this will copy the whole object, but I think that should be desired behaviour in this case. If you do not want to have dependencies then the user should make sure that there is no dependency set in the reference Job object. Preambles and postambles should also be copied over in my opinion. |
|
Nice addition! |
SiebeLeDe
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now works, but we should add some test-cases