-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
156 add support for removing virtual orbitals in adf calculations #165
Merged
SEBeutick
merged 20 commits into
main
from
156-add-support-for-removing-virtual-orbitals-in-adf-calculations
Mar 12, 2024
Merged
156 add support for removing virtual orbitals in adf calculations #165
SEBeutick
merged 20 commits into
main
from
156-add-support-for-removing-virtual-orbitals-in-adf-calculations
Mar 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sis-set-size 159 add information about basis set size
…sis-set-size We are now not rounding down half the number of electrons.
SiebeLeDe
requested changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, needs to raise an error when frozen core is not None
…tual-orbitals-in-adf-calculations' into 156-add-support-for-removing-virtual-orbitals-in-adf-calculations
SEBeutick
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good
YHordijk
deleted the
156-add-support-for-removing-virtual-orbitals-in-adf-calculations
branch
March 14, 2024 21:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a method for removing virtuals a priori