Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

115 deprecate adfjobscf convergence #116

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

YHordijk
Copy link
Contributor

@YHordijk YHordijk commented Feb 6, 2024

We have deprecated the ADFJob.SCF_convergence method in favor of the ADFJob.SCF method. Also added the iterations argument to ADFJob.SCF for setting the number of SCF iterations. This was needed for PyOrb.

@YHordijk YHordijk self-assigned this Feb 6, 2024
@YHordijk YHordijk linked an issue Feb 6, 2024 that may be closed by this pull request
@YHordijk YHordijk requested a review from SEBeutick February 6, 2024 16:25
@YHordijk YHordijk added the enhancement New feature or request label Feb 6, 2024
@SEBeutick SEBeutick merged commit 33ec052 into main Feb 6, 2024
6 checks passed
@YHordijk YHordijk deleted the 115-deprecate-adfjobscf_convergence branch February 6, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate ADFJob.SCF_convergence
2 participants