Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding irc calculations #104

Merged
merged 19 commits into from
Feb 6, 2024
Merged

Adding irc calculations #104

merged 19 commits into from
Feb 6, 2024

Conversation

YHordijk
Copy link
Contributor

@YHordijk YHordijk commented Feb 1, 2024

This PR brings support for IRC calculations

@YHordijk YHordijk linked an issue Feb 1, 2024 that may be closed by this pull request
@YHordijk YHordijk requested a review from SiebeLeDe February 1, 2024 19:55
@YHordijk YHordijk self-assigned this Feb 1, 2024
src/tcutility/job/generic.py Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plams uses a different method to clean calculation directories in which users can specify which files to keep. See
(this doc)[https://www.scm.com/doc/plams/components/results.html?highlight=keep#cleaning-for-multijobs]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, but we also have to support ORCA and CREST and possibly more engines. In that case I think we should just implement our own methods. I am also unsure if it is a good idea to let the user determine what files to keep. I think it is better to keep everything as simple as possible and hidden away from the user.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not think it is a good idea to let the user determine which files to keep. We need to make it indeed as simple as possible

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I think so too

@SiebeLeDe
Copy link
Contributor

You can merge it @YHordijk

@ToriGijzen ToriGijzen merged commit 51132ac into main Feb 6, 2024
6 checks passed
@ToriGijzen ToriGijzen deleted the adding-IRC-calculations branch February 6, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add post-job scripts to job module
3 participants