-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding irc calculations #104
Conversation
Parity with main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plams uses a different method to clean calculation directories in which users can specify which files to keep. See
(this doc)[https://www.scm.com/doc/plams/components/results.html?highlight=keep#cleaning-for-multijobs]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, but we also have to support ORCA and CREST and possibly more engines. In that case I think we should just implement our own methods. I am also unsure if it is a good idea to let the user determine what files to keep. I think it is better to keep everything as simple as possible and hidden away from the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not think it is a good idea to let the user determine which files to keep. We need to make it indeed as simple as possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I think so too
You can merge it @YHordijk |
This PR brings support for IRC calculations