Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a sorting function to pathfunc.match #330

Open
YHordijk opened this issue Dec 5, 2024 · 0 comments · May be fixed by #327
Open

Add a sorting function to pathfunc.match #330

YHordijk opened this issue Dec 5, 2024 · 0 comments · May be fixed by #327
Assignees
@YHordijk
Labels
enhancement New feature or request tcutility.pathfunc Issues related to the pathfunc module

Comments

@YHordijk
Copy link
Contributor

YHordijk commented Dec 5, 2024

The pathfunc.match function works very well at the moment. We can improve it by adding a new argument for sorting before supplying the results to the user. The function is not a generator so we can simply add a sorting call before returning the results.
@YHordijk YHordijk added enhancement New feature or request tcutility.pathfunc Issues related to the pathfunc module labels Dec 5, 2024
@YHordijk YHordijk self-assigned this Dec 5, 2024
YHordijk added a commit that referenced this issue Dec 5, 2024
@YHordijk
[#330] Added the sort_by kwarg to the pathfunc.match function
4c7c213
YHordijk added a commit that referenced this issue Dec 5, 2024
@YHordijk
[#330] Added the sort_by kwarg to the pathfunc.match function
231cd1e
@YHordijk YHordijk linked a pull request Dec 5, 2024 that will close this issue
Fixes for electrostatic decomposition analyses #327
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YHordijk YHordijk

Labels
enhancement New feature or request tcutility.pathfunc Issues related to the pathfunc module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes for electrostatic decomposition analyses TheoChem-VU/TCutility
1 participant
@YHordijk