fix: prevent a11y_label_has_associated_control false positive for c…

…omponent in `<label>` (sveltejs#12119) * fix: prevent `a11y_label_has_associated_control` false positive for component in `<label>` * fix render tags as well * Update .changeset/swift-rats-sing.md --------- Co-authored-by: Rich Harris <[email protected]> Co-authored-by: Rich Harris <[email protected]>
Theo-Steiner · Jun 21, 2024 · 5b60a0e · 5b60a0e
1 parent 965c12f
commit 5b60a0e
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 0 deletions.
diff --git a/.changeset/swift-rats-sing.md b/.changeset/swift-rats-sing.md
@@ -0,0 +1,5 @@
+---
+"svelte": patch
+---
+
+fix: prevent `a11y_label_has_associated_control` false positive for component or render tag in `<label>`
diff --git a/packages/svelte/src/compiler/phases/2-analyze/a11y.js b/packages/svelte/src/compiler/phases/2-analyze/a11y.js
@@ -1086,6 +1086,8 @@ function check_element(node, state) {
 						if (
 							node.type === 'SvelteElement' ||
 							node.type === 'SlotElement' ||
+							node.type === 'Component' ||
+							node.type === 'RenderTag' ||
 							(node.type === 'RegularElement' &&
 								(a11y_labelable.includes(node.name) || node.name === 'slot'))
 						) {

diff --git a/packages/svelte/tests/validator/samples/a11y-label-has-associated-control-2/input.svelte b/packages/svelte/tests/validator/samples/a11y-label-has-associated-control-2/input.svelte
@@ -1,3 +1,11 @@
+<script>
+  import Component from './component.svelte'
+</script>
+
 <label>
   <slot />
 </label>
+
+<label>
+  <Component />
+</label>
diff --git a/packages/svelte/tests/validator/samples/a11y-label-has-associated-control-3/input.svelte b/packages/svelte/tests/validator/samples/a11y-label-has-associated-control-3/input.svelte
@@ -0,0 +1,7 @@
+<script>
+  import Component from './component.svelte'
+</script>
+
+<label>
+  {@render x()}
+</label>
diff --git a/packages/svelte/tests/validator/samples/a11y-label-has-associated-control-3/warnings.json b/packages/svelte/tests/validator/samples/a11y-label-has-associated-control-3/warnings.json
@@ -0,0 +1 @@
+[]