Show iOS controls without using present full screen #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show controls without calling the present full screen method.
|
Can this get merged in please? |
|
Status on this? |
|
Maybe I'm missing something, but the only time I'm seeing createPlayerViewController get called is when I use presentFullscreenPlayer. Can you provide an example of how you're using this? It may also be that something has changed when they switched over to the new video player in iOS 11. Also, I don't think we want to make this mandatory behavior, some people are going to want to provide their own controls UI, so this should be an optional prop. |
|
Ok I finally figured out what was going on. I didn't realize that settings the controls prop caused it to create a view controller. Tested this and everything looks good, sorry about that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to show the controls without calling the present full screen method.