-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolved ignored silent switch in iOS when player is set to paused #2215
Conversation
…ilent switch” setting
Thank you for this PR. I am using your solution in our application. You shouldn't happen to have a fix for this issue as well..? :D |
glad there's a fix for this. Can we get this merged? |
is it possible to merge this fix? 😄 |
@nickfujita I would certainly love to get this merged in. Is there anything holding it back at this point? |
Whats keeping this from being merged? |
Thanks for the fix, @iamcam! |
any updates on that? |
Thanks for the fix @iamcam - have cherry picked that into our fork pending it being merged to master here 👍 |
Hi, is there any way to help to get this merged? |
Can we get this merged please? |
please merge this |
Would also like for this to be merged. 👍🏽 |
Is it possible to get this merged? Would really help a lot! |
Fix for tvOS native audio menu language selector
This resolves an issue where setting a video to paused would ignore the “silent switch” setting, as reported in #2157. By moving the audio configuration outside of the
paused
setter, we can update as needed when thesilenced
variable is set/changed, as one would expect.To Test