Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved ignored silent switch in iOS when player is set to paused #2215

Merged
merged 3 commits into from
Sep 9, 2021

Conversation

iamcam
Copy link

@iamcam iamcam commented Nov 20, 2020

This resolves an issue where setting a video to paused would ignore the “silent switch” setting, as reported in #2157. By moving the audio configuration outside of the paused setter, we can update as needed when the silenced variable is set/changed, as one would expect.

To Test

  • Create a video component that is...
    • set to paused
    • set fullscreen to true
    • ignoreSilentSwitch = 'ignore'
  • Set the iPhone to "silenced" mode via the switch on the side
  • Play the video.
  • You should be able to hear audio playing (previously it was not)

@jfbn
Copy link

jfbn commented Dec 9, 2020

Thank you for this PR. I am using your solution in our application.

You shouldn't happen to have a fix for this issue as well..? :D

@vyao95
Copy link

vyao95 commented Dec 11, 2020

glad there's a fix for this. Can we get this merged?

@emil-malmgaard-rasmussen

is it possible to merge this fix? 😄

@iamcam
Copy link
Author

iamcam commented Jan 18, 2021

@nickfujita I would certainly love to get this merged in. Is there anything holding it back at this point?

@emil-malmgaard-rasmussen

Whats keeping this from being merged?

@jamesdarabi
Copy link

Thanks for the fix, @iamcam!

@andrew-stupchuk
Copy link

any updates on that?

@elandesign
Copy link

Thanks for the fix @iamcam - have cherry picked that into our fork pending it being merged to master here 👍

@ZeroPie
Copy link

ZeroPie commented Apr 27, 2021

Hi, is there any way to help to get this merged?

@emil-malmgaard-rasmussen

Can we get this merged please?

@androidparth90
Copy link

please merge this

@geegonzalez
Copy link

Would also like for this to be merged. 👍🏽

@emil-malmgaard-rasmussen

Is it possible to get this merged? Would really help a lot!

@smaccoun
Copy link

smaccoun commented Sep 9, 2021

Tagging @zchwyng @cobarx
I think this one is really valuable and safe to merge.
Several of us have forked and I know I've tested it quite a bit in production

@zchwyng zchwyng merged commit bf11502 into TheWidlarzGroup:master Sep 9, 2021
nickfujita added a commit to crunchyroll/react-native-video that referenced this pull request Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.