Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear progress messages on STATE_IDLE and STATE_BUFFERING #1768

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Clear progress messages on STATE_IDLE and STATE_BUFFERING #1768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,18 +625,20 @@ public void onPlayerStateChanged(boolean playWhenReady, int playbackState) {
case Player.STATE_IDLE:
text += "idle";
eventEmitter.idle();
clearProgressMessageHandler();
break;
case Player.STATE_BUFFERING:
text += "buffering";
onBuffering(true);
clearProgressMessageHandler();
break;
case Player.STATE_READY:
text += "ready";
eventEmitter.ready();
onBuffering(false);
startProgressHandler();
videoLoaded();
//Setting the visibility for the playerControlView
// Setting the visibility for the playerControlView
if (playerControlView != null) {
playerControlView.show();
}
Expand All @@ -657,6 +659,15 @@ private void startProgressHandler() {
progressHandler.sendEmptyMessage(SHOW_PROGRESS);
}

/*
The progress message handler will duplicate recursions of the onProgressMessage handler
on change of player state from any state to STATE_READY with playWhenReady is true (when
the video is not paused). This clears all existing messages.
*/
private void clearProgressMessageHandler() {
progressHandler.removeMessages(SHOW_PROGRESS);
}

private void videoLoaded() {
if (loadVideoStarted) {
loadVideoStarted = false;
Expand Down