Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Videos Without Text Tracks Should Be Cached #1387

Closed
wants to merge 4 commits into from
Closed

Videos Without Text Tracks Should Be Cached #1387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aadd92b
Fix cache being bypassed when no text tracks are passed
brendangkchan Dec 15, 2018
3ebb7a6
4.2.1
brendangkchan Dec 15, 2018
e762167
4.2.2
brendangkchan Dec 15, 2018
68739d1
Remove changelog entry for text tracks caching
cobarx Feb 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ios/Video/RCTVideo.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,7 @@ - (void)playerItemForSource:(NSDictionary *)source withCallback:(void(^)(AVPlaye
[assetOptions setObject:cookies forKey:AVURLAssetHTTPCookiesKey];

#if __has_include(<react-native-video/RCTVideoCache.h>)
if (!_textTracks) {
if (_textTracks) {
/* The DVURLAsset created by cache doesn't have a tracksWithMediaType property, so trying
* to bring in the text track code will crash. I suspect this is because the asset hasn't fully loaded.
* Until this is fixed, we need to bypass caching when text tracks are specified.
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-native-video",
"version": "4.2.0",
"version": "4.2.2",
"description": "A <Video /> element for react-native",
"main": "Video.js",
"license": "MIT",
Expand Down Expand Up @@ -36,7 +36,7 @@
"dependencies": {
"keymirror": "0.1.1",
"prop-types": "^15.5.10",
"shaka-player": "2.4.4"
"shaka-player": "2.4.4"
},
"scripts": {
"test": "node_modules/.bin/eslint *.js"
Expand All @@ -46,7 +46,7 @@
"sourceDir": "./android-exoplayer"
}
},
"files":[
"files": [
"android-exoplayer",
"android",
"dom",
Expand Down