Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-native-dom: DASH & HLS support, autoplay detection #1284

Merged
merged 2 commits into from
Oct 12, 2018

Conversation

cobarx
Copy link
Contributor

@cobarx cobarx commented Oct 12, 2018

Adds an id prop to set the DOM id on the html

Add handling when autoplay is disabled on react-native-dom targets. When the video starts to play, if autoplay is disabled, react-native-video should generate an onError event with the following payload:

{
  code: "NotAllowedError",
  message: "The request is not allowed by the user agent or the platform in the current context, possibly because the user denied permission."
}

It can also generate an error with a code of NotSupportedError if the video is a type (e.g. MKV) that's not supported by the browser. I will add docs for both of these later.

@cobarx cobarx merged commit 97604f8 into master Oct 12, 2018
@cobarx cobarx deleted the feature/shaka-player branch October 12, 2018 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant