Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introducing onExternalPlaybackChange #1235

Merged
merged 4 commits into from
Oct 7, 2018

Conversation

arturjaworski
Copy link
Contributor

@arturjaworski arturjaworski commented Sep 14, 2018

adds possiblity to get AVPlayer.externalPlaybackActive flag

@arturjaworski arturjaworski changed the title introducing onExternalPlaybackActiveChange introducing onExternalPlaybackChange Sep 14, 2018
@cobarx
Copy link
Contributor

cobarx commented Sep 14, 2018

Hi @arturjaworski, this looks great and appears to being pretty close to being ready to merge.

Can you document this in the README file including what the event payload looks like and also provide instructions on how to test this. I'm ordering an Apple TV for testing which should arrive late next week where I can test this.

@arturjaworski
Copy link
Contributor Author

@cobarx updated :)

@cobarx
Copy link
Contributor

cobarx commented Sep 22, 2018

What do I need to do to test this, I'm not too familiar with doing external playback.

@arturjaworski
Copy link
Contributor Author

Please try to connect/disconnect to AirPlay. Some AirPlay server should be enough (eg. Reflector 3). onExternalPlaybackChange will be called on connection/disconnection. Just let me know if you'll have any problem! :)

@cobarx cobarx merged commit 2688dd9 into TheWidlarzGroup:master Oct 7, 2018
@cobarx
Copy link
Contributor

cobarx commented Oct 7, 2018

Tested this with my new AppleTV and it worked great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants