Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tc issue 98 #101

Merged
merged 7 commits into from
Sep 7, 2018
Merged

Tc issue 98 #101

merged 7 commits into from
Sep 7, 2018

Conversation

vsperez
Copy link
Member

@vsperez vsperez commented Aug 19, 2018

Adds synoptic view over GTFSFileProcess and trip canceling

vperez added 2 commits August 19, 2018 20:16
- Add length and directionId fields to shape
- Add pathLength to stop
- Add synoptic jsp,js and css
@vsperez
Copy link
Member Author

vsperez commented Aug 19, 2018

Hi,

I add the synoptic view.

During the implementation, I realized about one thing I did not see, so I have a question.

What happens with the stop distance over the shape when there is more than one trip pattern?. I have seen something like minor property. The vehicle information is easy, you can get the projection over the route according to the shape associated, but on the stops I did not see that.

It is still pending to deal with canceled trips.

There is an small issue regarding the stop paths distances, the sum of all are greater than the shape length.

- Change of icons.
- Corrections in ccs and popup arrows placement
@vsperez
Copy link
Member Author

vsperez commented Aug 27, 2018

Hi Sean,

I was thinking to add headway information to the vehicle tooltip or lable. How can I get that information?. What do you think is better: to read it periodically or by demand?

Best regards
Vicente

Vicente Pérez and others added 4 commits August 28, 2018 14:46
into tc_issue_98

# Conflicts:
#	transitclock/pom.xml

- Add headway information to synoptic view
- Add color of bus according to schAdh
- Needed to be tested in two directions route
- Merge develop and tc_issue_74
@scrudden
Copy link
Member

scrudden commented Sep 7, 2018

@vsperez Am I correct to presume there are no breaking changes in this pull request. By that I mean, there are no changes that will break the predictions. It only effects reporting.

@vsperez
Copy link
Member Author

vsperez commented Sep 7, 2018

Hi Sean,

As far as I can tell, there are no changes that might affect prediction or other parts of the core processing. All changes are in ipc objects, api objects and Web interface. If you find a change in the core (except for the if obj ==null in the headway generator), please let me know.

@scrudden scrudden merged commit fa7e7d9 into TheTransitClock:develop Sep 7, 2018
@scrudden scrudden mentioned this pull request Sep 7, 2018
@vsperez
Copy link
Member Author

vsperez commented Sep 7, 2018

This is a screen shot of the new view
screen shot 2018-09-04 at 09 55 22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants