Fix CPU being turned off. #48
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add additional wakelock to handle screen state. - Add additional broadcastreceiver to handle screen commands separately.
✅ Deploy Preview for wallpanel canceled.
|
This was referenced Nov 6, 2022
|
@TheTimeWalker Any chance you can find some time to review the changes in this PR? |
|
It looks like this functionality breaks when brightness control permissions are granted. I'll check why this happens. |
|
@TheTimeWalker Would be great to have it reviewed and merged! |
|
@amasolov It is still regarded as Draft so I've been holding off of reviewing |
|
I'll try to find some time in the coming days or weeks to take a look at the remaining issues with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the issue seen in #39.
The wakelock was only kept for 3 seconds so when the screen was turned off, the CPU was also turned off.
In order to fix this, a few things needed to happen:
Please review these changes and test them yourself since I'm not an Android dev so maybe things should be done differently.
This PR might also impact battery life since the CPU will never be turned off while WallPanel is running.
Maybe you can create a Pre-release for this one so other people can also test it first?