Mqtt and other small fixes #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove MQTT3 disconnect exception handling MQTT5 service. - Remove MQTT5 disconnect exception handling MQTT3 service. - Correct wrong set of mReady (should be false) and wrong call of handleMqttConnected (should be handleMqttDisconnected)
- Fixed typo. - Remove irrelevant mqttConnected variable - Use displayManager to get real display state (see bottom remark of: https://developer.android.com/reference/android/os/PowerManager#isScreenOn())
✅ Deploy Preview for wallpanel canceled.
|
|
Thank you very much for looking into this issue! I will look into the PR in the following days |
|
LGTM! |
|
Thanks for merging! Is there also a new release going to be published? |
|
Yes, hopefully today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29
I've managed to fix the issues I was facing in #29.
The mqtt reconnect logic suffered the same issue. Basically it was possible that multiple callbacks were added to the handlers.
I've added a cleanup before every addition to the handlers to make sure only one callback will be in the handler.
I'm not an android developer so I've basically just hardened the logic to prevent the issue from happening.
I've also did some other minor fixes like using the displaymanager to get the state of the screen since "isInteractive" on the power manager doesn't necessarily represents the correct screen state (https://developer.android.com/reference/android/os/PowerManager#isInteractive())