Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix floating point comparison #167

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Conversation

petitnau
Copy link
Contributor

@petitnau petitnau commented Feb 2, 2023

After #131, the fgt.* t0, t1, t2 and fge.* t0, t1, t2 pseudo-instructions are defined, respectively, as fle.* t0, t2, t1 and flt.* t0, t2, t1.
However, they should be defined as flt.* t0, t2, t1 and fle.* t0, t2, t1, as x > y <=> y < x and x >= y iff y <= x.

@TheThirdOne
Copy link
Owner

I am a little surprised that the psuedo intructions were wrong after being corrected. I was clearly not thinking about correctness when I wrote them.

@TheThirdOne TheThirdOne merged commit 5e8dd10 into TheThirdOne:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants