Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default pagination limit to Redis #7418

Draft
wants to merge 7 commits into
base: v3.33
Choose a base branch
from

Conversation

halimi
Copy link
Contributor

@halimi halimi commented Dec 3, 2024

Summary

References: https://github.com/TheThingsIndustries/lorawan-stack/issues/4441

Add default pagination limit to List querys in AS, JS, NS.

Changes

  • Add default pagination limit to
    • ApplicationPackageRegistry/List
    • ApplicationPackageRegistry/ListAssociations
    • ApplicationPackageRegistry/ListDefaultAssociations
    • ApplicationPubSubRegistry/List
  • ...

Testing

Steps

...

Results
Regressions

...

Notes for Reviewers

...

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@halimi halimi self-assigned this Dec 3, 2024
@github-actions github-actions bot added c/application server This is related to the Application Server compat/db This could affect Database compatibility compat/config This could affect Configuration compatibility labels Dec 3, 2024
@halimi halimi added this to the v3.33.1 milestone Dec 3, 2024
@github-actions github-actions bot added the c/network server This is related to the Network Server label Dec 4, 2024
@halimi halimi force-pushed the feature/redis-default-pagination-limit branch from 6e96683 to f92906f Compare December 4, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/application server This is related to the Application Server c/network server This is related to the Network Server compat/config This could affect Configuration compatibility compat/db This could affect Database compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant