Skip to content

Commit

Permalink
Merge pull request #2530 from TheThingsNetwork/feature/gh-templates-t…
Browse files Browse the repository at this point in the history
…esting

Include testing considerations in issue and PR templates
  • Loading branch information
Krishna Iyer Easwaran authored May 18, 2020
2 parents f0a90f5 + bcc6429 commit 5ee4942
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 4 deletions.
9 changes: 6 additions & 3 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@ If you use the command "ttn-lw-stack config", you can redact sensitive config.
-->

#### What do you see now?
<!--
Please paste terminal output, upload logs (as .txt) or upload screenshots.
-->
<!-- Please paste terminal output, upload logs (as .txt) or upload screenshots. -->

...

Expand All @@ -50,6 +48,11 @@ Paste the output of "ttn-lw-cli version" or "ttn-lw-stack version" if applicable

...

#### How do you propose to test this?
<!-- Please think about how this is verified as fixed. -->

...

#### Can you do this yourself and submit a Pull Request?
<!-- You can also @mention experts if you need help with this. -->

Expand Down
8 changes: 8 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,14 @@ Paste the output of "ttn-lw-cli version" or "ttn-lw-stack version" if applicable

...

#### How do you propose to test this?
<!--
Please think about how this is verified as implemented.
For example, you can add what commands need to be run via the CLI/Console to verify that this works.
-->

...

#### Can you do this yourself and submit a Pull Request?
<!-- You can also @mention experts if you need help with this. -->

Expand Down
14 changes: 13 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,19 @@ Closes #0000, References #0000, etc.
- ...
- ...


#### Testing

<!-- How did you verify that this change works? -->

...

##### Regressions

<!-- Please indicate features that this change could affect and how that was tested. -->

...

#### Notes for Reviewers
<!--
NOTE: This section is optional.
Expand All @@ -34,7 +47,6 @@ implementation proposal in the referenced issues.

- [ ] Scope: The referenced issue is addressed, there are no unrelated changes.
- [ ] Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in `README.md`. The target branch is set to `master` if the changes are fully compatible with existing API, database, configuration and CLI.
- [ ] Testing: The changes are covered with unit tests. The changes are tested manually as well.
- [ ] Documentation: Relevant documentation is added or updated.
- [ ] Changelog: Significant features, behavior changes, deprecations and fixes are added to `CHANGELOG.md`.
- [ ] Commits: Commit messages follow guidelines in `CONTRIBUTING.md`, there are no fixup commits left.

0 comments on commit 5ee4942

Please sign in to comment.