Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: GLA Buildings Sometimes Don't Create Scrap When They Destroy Enemy Vehicles #89

Closed
wants to merge 2 commits into from

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Aug 28, 2021

ZH 1.04:

  • GLA buildings do not create scrap consistently. A Tunnel Network will not create scrap while a Stinger Site does... sometimes. Except a Demo Stinger Site when kills by Suicide. And except ... bla bla

With this patch:

  • GLA buildings create scrap when they kill enemy vehicles no questions asked.

@commy2 commy2 added the Bug Something is not working right label Aug 28, 2021
@xezon xezon self-requested a review August 29, 2021 09:53
@xezon
Copy link
Collaborator

xezon commented Aug 29, 2021

The title says "sometimes". Is it really just sometimes? I am asking because this has gameplay/balance implications if we grant GLA more scrap from kills. If it is not random, then this is a balancing concern and not a bug fix and should not be submitted without permission of the balancing team.

Copy link
Collaborator

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

@commy2
Copy link
Collaborator Author

commy2 commented Aug 29, 2021

Is it really just sometimes?

Example is that Tunnels do not create scrap, so if the killshot comes from the Tunnel, you don't get scrap even though you popped 10 Quads.

Stingers however do create scrap, because the Stinger Soldiers are set up like any other infantry and those are the objects that actually make the kill.

But the Stinger Site building itself is not set up to create scrap, which means that if you suicide a Demo General Stinger Site, it does not create scrap.

I find this all confusing and would rather have it that GLA creates scrap when they kill a vehicle with their units (and buildings). This takes away that randomness and makes the game more predictable.

@xezon
Copy link
Collaborator

xezon commented Aug 29, 2021

Yes. These area reasonable arguments. Consistent behavior certainly is desirable.

@Jundiyy
Copy link
Collaborator

Jundiyy commented Aug 29, 2021

It is already consistent if you look at it from a different angle. Anything which is 'human' based will kill and give scrap.
Normal units kill and give scrap
Stinger Sites have units inside which kill and give scrap
Tunnel Networks have no units, hence no scrap
Stinger Site blowing up is the building being blown up not the units doing suicide, hence no scrap.

Seems logical.

@commy2 commy2 changed the title Fix: GLA Buildings Sometimes Don't Create Scrap When They Destroy Enemy Vehicles [Discussion ongoing] Fix: GLA Buildings Sometimes Don't Create Scrap When They Destroy Enemy Vehicles Aug 29, 2021
@commy2 commy2 changed the title [Discussion ongoing] Fix: GLA Buildings Sometimes Don't Create Scrap When They Destroy Enemy Vehicles Fix: GLA Buildings Sometimes Don't Create Scrap When They Destroy Enemy Vehicles Aug 29, 2021
@commy2 commy2 added OngoingDiscussion Requires further discussion and removed help wanted labels Aug 29, 2021
@ReLaX82
Copy link

ReLaX82 commented Aug 29, 2021

If that what you write is true and not a random behaviour, I would simply close this point and just state somewhere to anyone that it has been observed and decided as no bug.

@KaSSaDo
Copy link

KaSSaDo commented Sep 1, 2021

I have always thought GLA buildings don't get scrap from destroyed vehicles whereas GLA units do. Stinger Sites should always create scrap, is it really only "sometimes"? This should be consistent. RPGs shooting from inside Palace also generate scrap.

If tunnels get scrap from vehicles that would be a huge boost for GLA which should be avoided in my opinion.

@Jundiyy
Copy link
Collaborator

Jundiyy commented Sep 1, 2021

I have always thought GLA buildings don't get scrap from destroyed vehicles whereas GLA units do. Stinger Sites should always create scrap, is it really only "sometimes"? This should be consistent. RPGs shooting from inside Palace also generate scrap.

If tunnels get scrap from vehicles that would be a huge boost for GLA which should be avoided in my opinion.

It's not 'sometimes', Stinger Soldiers always give scrap. The one time 'they' don't is when you suicide the Demo Stinger Site (after upgrade) and the reason you don't is because it is the building doing the damage and not the units. Hence in such a state it's following the Tunnel Network.

@xezon
Copy link
Collaborator

xezon commented Sep 1, 2021

Given the explanation from Jundiyy that buildings cannot create scrap in original game, I think this is perfectly ok and we don't need to change anything here. It's not a bug, but a design decision.

@Stubbjax
Copy link
Collaborator

Stubbjax commented Sep 1, 2021

Should demo traps create scrap?

@Jundiyy
Copy link
Collaborator

Jundiyy commented Sep 1, 2021

For what reason? It's not a unit but a building.

@xezon xezon added Design Is a matter of game design WontChange This will not be worked on and removed Bug Something is not working right OngoingDiscussion Requires further discussion labels Sep 3, 2021
@xezon xezon closed this Sep 3, 2021
@commy2 commy2 deleted the fix-base-defense-scrap-creation branch September 3, 2021 10:21
@commy2 commy2 restored the fix-base-defense-scrap-creation branch September 3, 2021 10:21
@commy2 commy2 mentioned this pull request Sep 21, 2021
@xezon xezon deleted the fix-base-defense-scrap-creation branch August 30, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Is a matter of game design WontChange This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants