Clean Up Dummy Upgrade Code #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
reviewed
Aug 6, 2022
xezon
approved these changes
Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires and forks Make Dummy Upgrade Global #830
Remove the superfluous
ExemptStatus.ExemptStatusflag does nothing here.GrantUpgradeCreateis only triggered once the scaffold is completed (or the unit leaves a factory or the at the start of the map for preplaced objects).Use
Upgrade_DummyUpgradeinstead ofUpgrade_ChinaOverlordGattlingCannonon the vUSA SDZ. This appears to be a minor mistake.Despite this being a global upgrade, I left it so the buildings grant it. This helps for maps where the player does not chose their faction.