Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Remove Demo GLA Terror Combat Bike suicide damage to allies before Demo Upgrade #783

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Fix: Remove Demo GLA Terror Combat Bike suicide damage to allies before Demo Upgrade #783

merged 1 commit into from
Aug 4, 2022

Conversation

xezon
Copy link
Collaborator

@xezon xezon commented Jul 29, 2022 •
edited
Loading

Demo GLA Terror Combat Bike no longer damages allies before Demo Upgrade.

Original

Object Damages ALLIES
Demo Terrorist without Upgrade
Demo Terrorist with Upgrade
Demo Bike without Upgrade x
Demo Bike with Upgrade
Regular Terrorist x
Regular Terror Bike x
Stealth Terror Bike x

Patched

Object Damages ALLIES
Demo Terrorist without Upgrade
Demo Terrorist with Upgrade
Demo Bike without Upgrade
Demo Bike with Upgrade
Regular Terrorist x
Regular Terror Bike x
Stealth Terror Bike x

Rationale

All Terrorists behave the same with Demo General. No inconsistencies.

Proof of change

shot_20220729_163451_2

@xezon xezon added Bug Something is not working right Controversial Is controversial Minor Severity: Minor < Major < Critical < Blocker labels Jul 29, 2022
@commy2
Copy link
Collaborator

commy2 commented Aug 4, 2022

A Terrorist damages allies. Why does he no longer do that when on a bike? The change makes no sense to me.

@xezon
Copy link
Collaborator Author

xezon commented Aug 4, 2022

He does not damage allies.

@commy2
Copy link
Collaborator

commy2 commented Aug 4, 2022

Nvm, I was thinking about xGLA Terrorist and not the Demo one.

@xezon xezon merged commit 7427cf7 into main Aug 4, 2022
@xezon xezon deleted the fix-demo-bike-allies-dmg branch August 4, 2022 17:56
xezon added a commit that referenced this pull request Aug 28, 2022
@xezon
Change: Remove Demo GLA Combat Bike suicide damage to allies before D…
b035799 
…emo Upgrade (#783)
@ImTimK ImTimK added the GLA Affects GLA faction label Nov 7, 2022
@xezon xezon changed the title Remove Demo GLA Terror Combat Bike suicide damage to allies before Demo Upgrade Fix: Remove Demo GLA Terror Combat Bike suicide damage to allies before Demo Upgrade Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Something is not working right Controversial Is controversial GLA Affects GLA faction Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GLA Demo Bike applies damage to ALLIES before Demo Upgrade
3 participants
@xezon @commy2 @ImTimK