Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 1.04+ Cross Faction Rebel Ambush Compatibility #562

Merged
merged 1 commit into from
Dec 24, 2021
Merged

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Oct 15, 2021

@commy2 commy2 added the Bug Something is not working right label Oct 15, 2021
@commy2 commy2 changed the title Fix: 1.04+ Cross Faction Ambush Compatibility [WIP] Fix: 1.04+ Cross Faction Rebel Ambush Compatibility Oct 15, 2021
@commy2 commy2 changed the title [WIP] Fix: 1.04+ Cross Faction Rebel Ambush Compatibility Fix: 1.04+ Cross Faction Rebel Ambush Compatibility Oct 15, 2021
@commy2
Copy link
Collaborator Author

commy2 commented Oct 15, 2021

This patch will re-enable the broken 5 minute timer that is intended for Demo and Tox General in 1.04+. (Normal Ambush and all 1.04 Ambush are 4 minutes).

Currently on main branch all Rebel Ambush are 4 minutes, due to the partial implementation of faction specific special powers.

To get the timers to work and still not break the special power shortcut button, Demo will now always spawn Demo Rebels and Tox will now always spawn Tox Rebels, no matter what Command Center was captured.

This also enables us to adjust the description of the powers in the generals promotion menu. Currently (in 1.04) there is an un-used text that specifies "Toxin Rebels" for the Tox General version of Rebel Ambush. Additionally, currently (1.04) the Demo Rebel Ambush will claim the wrong amount of Demo Rebels to be spawned (the Demo Rebel count was reduced in 1.02 or 1.03 Zero Hour to balance it).

Q:

Is the 5 minute timer the right approach to balance Tox and Demo Rebel Ambushes? One alternative would be (further) cutting down the Rebel count for both.

@commy2 commy2 merged commit 50ba5a3 into main Dec 24, 2021
@commy2 commy2 deleted the fix-ambush branch December 24, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Demo_SuperweaponRebelAmbush setup appears to be incomplete
2 participants