Fix: Powered Arms Dealer Door Still Open When Chain Building Technicals and Combat Bikes

[commy2]

• ref Review factory door times #464 (comment)

ZH 1.04:

door.mp4

Patch:

door-gla-fixed.mp4

[commy2]

Aside from visuals, this means that Technical build time is 12 sec w/o power and 7 sec w/ power now always.

In 1.04, it is - with power - 7 seconds for the first Technical only, and 5 seconds starting from the second Technical.

[xezon]

Hmm. Wouldn't it have been enough to just decrease DoorWaitOpenTime by a few milliseconds? I don't understand why 2 variables had to be changed. Plus now Door close is quicker than door open. Why?

[commy2]

Plus now Door close is quicker than door open. Why?

The time it takes for the door to close is animation based, so part of the model. DoorCloseTime is used to make the logic register that the door was already closed. You could set DoorCloseTime to 2 minutes and it wouldn't speed up / slow down the animation at all.

Wouldn't it have been enough to just decrease DoorWaitOpenTime by a few milliseconds?

The game is not precise enough for a few msecs to mean anything. It runs at 30 FPS in multiplayer, so to make an actual difference, you need at least 33.33 msecs (= 1 frame).

[commy2]

This may help:

Edit: oops, replace "fps" with "milliseconds per frame". 1/30 FPS = 0.033 seconds per frame.

[commy2]

Condition for not bugging out door opening for fast building units:
DoorWaitOpenTime + DoorCloseTime < (fastest) BuildTime
2000 msec + 1800 msec < 4.0 sec (Combat Bike w/ power)
3800 msec < 4000 msec, check

Condition for not bugging out door animation:
<animation frame count> / 30 FPS < DoorCloseTime
50 (Arms Dealer) / 30 FPS < 1800 msec
1667 msec < 1800 msec, check

[commy2]

DoorOpeningTime and DoorCloseTime do not determine the speed of the door animation. To not bug out the visuals, these must be bigger than the actual door animation time though.

DoorOpeningTime is important in that it adds a constant to actual build-time of units.

DoorCloseTime and DoorWaitOpenTime are less important, but must together be smaller than the fastest BuiltTime of any unit, otherwise the DoorOpeningTime delay is skipped.

If necessary, the door animations can be adjusted by using AnimationSpeedFactorRange in the W3DModelDraw module. That parameter can be used indepentently for door opening and closing.

[xezon]

Ok now it makes sense. Bike build is 4000 ms. I was wondering why door close time is combined 3800 ms when Technical build is 5000 ms. What you refer to as "milliseconds per frame" is called "frame time" in programmer terms.

[xezon]

Thank you for detailed investigation and explanations!