Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Boss Destroyed American Buildings Spawn Wrong Ranger Type #388

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Fix: Boss Destroyed American Buildings Spawn Wrong Ranger Type #388

merged 1 commit into from
Sep 21, 2021

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Sep 19, 2021

ZH 1.04

  • Boss General Fusion Reactor, Patriot Battery and Particle Cannon drop the normal USA Rangers when destroyed instead of the Boss General's Rangers.

After patch:

  • The Boss General buildings drop the Boss General Rangers.

I also renamed hanfields object creation lists from PR-#73. {faction}_OCL_whatever is consistent with the OCL's EA already uses.

Note that Boss_OCL_AmericanRangerDebris03 already exists (as well as the unused Boss_OCL_AmericanRangerDebris04). Boss_OCL_AmericanRangerDebris02 however did not, so it had to be added.

@commy2 commy2 added the Bug Something is not working right label Sep 19, 2021
xezon
xezon requested changes Sep 21, 2021
View reviewed changes
Copy link
Collaborator

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check OCL name changes.

Patch104pZH/GameFilesEdited/Data/INI/Object/AirforceGeneral.ini Show resolved Hide resolved
@commy2 commy2 merged commit 2bbbeea into main Sep 21, 2021
@commy2 commy2 deleted the fix-boss-ranger-type branch September 21, 2021 15:49
commy2 added a commit that referenced this pull request Oct 1, 2021
@commy2
Fix: Boss Destroyed American Buildings Spawn Wrong Ranger Type (#388)
57b26af
xezon pushed a commit that referenced this pull request Aug 28, 2022
@commy2
Fix: Boss Destroyed American Buildings Spawn Wrong Ranger Type (#388)
5a820ac
@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Boss Affects Boss faction labels Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xezon xezon xezon approved these changes

Assignees
No one assigned
Labels
Boss Affects Boss faction Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@commy2 @xezon