Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Boss Nationalism Upgrade Changes Tooltip After Landmines Upgrade #378

Merged
merged 2 commits into from
Sep 18, 2021
Merged

Fix: Boss Nationalism Upgrade Changes Tooltip After Landmines Upgrade #378

merged 2 commits into from
Sep 18, 2021

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Sep 17, 2021

ZH 1.04:

  • The tooltip for Nationalism on the Boss General's Nuclear Missile Silo initially says: "+25% to Horde bonus for Tank Hunter". After purchasing the Landmines upgrade, the tooltip updates to "+25% to Horde bonus for Red Guard, Tank Hunter and Battlemaster". However, the Boss General cannot build Red Guards and Battlemasters.
  • wtf

Patch:

  • The Nationalism upgrade does not change tooltip after the Landmines upgrade.

@commy2 commy2 added the Bug Something is not working right label Sep 17, 2021
@xezon xezon self-requested a review September 18, 2021 07:52
@commy2 commy2 merged commit 688e669 into main Sep 18, 2021
@commy2 commy2 deleted the fix-boss-nationalism branch September 18, 2021 21:03
commy2 added a commit that referenced this pull request Oct 1, 2021
@commy2
Fix: Boss Nationalism Upgrade Changes Tooltip After Landmines Upgrade (…
1f74c80 
…#378)
xezon pushed a commit that referenced this pull request Aug 28, 2022
@commy2
Fix: Boss Nationalism Upgrade Changes Tooltip After Landmines Upgrade (…
1774b9f 
…#378)
@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Text Is text, string, localization related Boss Affects Boss faction labels Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xezon xezon xezon approved these changes

Assignees
No one assigned
Labels
Boss Affects Boss faction Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker Text Is text, string, localization related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@commy2 @xezon