Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Anthrax Beta And Gamma Upgrade Icons Missing From Many Objects #355

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Fix: Anthrax Beta And Gamma Upgrade Icons Missing From Many Objects #355

merged 1 commit into from
Sep 14, 2021

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Sep 13, 2021

ZH 1.04

  • A lot of units and buildings benefit from the Anthrax Beta and Anthrax Gamma upgrade, but do not display the respective upgrade icon.
  • Sometimes the upgrade icon order is inconsistent with other units or the same unit of another sub-faction.

After patch:

  • The Anthrax upgrade icons are where they should be.

@commy2 commy2 added the Bug Something is not working right label Sep 13, 2021
@xezon xezon self-requested a review September 13, 2021 21:09
xezon
xezon reviewed Sep 13, 2021
View reviewed changes
Patch104pZH/GameFilesEdited/Data/INI/Object/DemoGeneral.ini

UpgradeCameo1 = Upgrade_GLAAnthraxBeta
UpgradeCameo2 = Upgrade_GLAJunkRepair
UpgradeCameo3 = Demo_Upgrade_SuicideBomb
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This order looks different to Demo_GLATankScorpion

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but the logic here is: vanilla Tractor icons + Suicide on the next free slot.

Patch104pZH/GameFilesEdited/Data/INI/Object/DemoGeneral.ini
UpgradeCameo1 = Upgrade_GLABombTruckHighExplosiveBomb
UpgradeCameo2 = Upgrade_GLAJunkRepair
;UpgradeCameo2 = Upgrade_GLABombTruckBioBomb
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now cameo 2 is empty. Is that intended?

Copy link
Collaborator Author

@commy2 commy2 Sep 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Bio Bomb is there for the other sub-factions. This signals: No Bio-Bomb for Demo. Same for: No HE-Bomb for Tox (also empty spot).

@xezon xezon self-requested a review September 14, 2021 16:54
@commy2 commy2 merged commit 403b8a4 into main Sep 14, 2021
@commy2 commy2 deleted the fix-anthrax-upgrade-icons branch September 14, 2021 16:58
commy2 added a commit that referenced this pull request Oct 1, 2021
@commy2
Fix: Anthrax Beta And Gamma Upgrade Icons Missing From Many Objects (#…
5e5f202 
…355)
xezon pushed a commit that referenced this pull request Aug 28, 2022
@commy2
Fix: Anthrax Beta And Gamma Upgrade Icons Missing From Many Objects (#…
cf491ab 
…355)
@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker GLA Affects GLA faction GUI For graphical user interface labels Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xezon xezon xezon approved these changes

Assignees
No one assigned
Labels
Bug Something is not working right GLA Affects GLA faction GUI For graphical user interface Minor Severity: Minor < Major < Critical < Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@commy2 @xezon