Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Paradrop Ability Spawns Wrong Ranger Type #286

Merged
merged 1 commit into from
Sep 11, 2021
Merged

Fix: Paradrop Ability Spawns Wrong Ranger Type #286

merged 1 commit into from
Sep 11, 2021

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Sep 11, 2021

ZH 1.04:

  • Paradrop ability always spawns the Rangers of the normal USA faction, even as Air Force, Super Weapon or Laser General.

Repro:

  • Build a Ranger as Air Force General. Use the Paradrop ability. Double click on a Ranger -> won't select both

After patch:

  • The Rangers from the correct sub-faction are dropped via Paradrop, so they can be easily selected by double clicking when mixed with Barracks build Rangers or Rangers dropped from destroyed buildings.

@commy2 commy2 added the Bug Something is not working right label Sep 11, 2021
xezon
xezon approved these changes Sep 11, 2021
View reviewed changes
Patch104pZH/GameFilesEdited/Data/INI/ObjectCreationList.ini
End
;RequiresLivePlayer = Yes ; I want to require a live player, but I'll settle for dropping neutral rangers instead
End
DeliverPayload
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the Paradrop3 have 2 identical DeliverPayloads? It's 2 planes coming?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it's split between two planes.

@commy2 commy2 merged commit 577229a into main Sep 11, 2021
@commy2 commy2 deleted the fix-paradrop-ranger-faction branch September 11, 2021 09:33
xezon pushed a commit that referenced this pull request Aug 28, 2022
@commy2
Fix: Paradrop Ability Spawns Wrong Ranger Type (#286)
2a45f05
@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker USA Affects USA faction labels Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Generalcamo Generalcamo Generalcamo left review comments

@xezon xezon xezon approved these changes

Assignees
No one assigned
Labels
Bug Something is not working right Minor Severity: Minor < Major < Critical < Blocker USA Affects USA faction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@commy2 @Generalcamo @xezon