Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nuclear Missile exploit fix #209

Merged
merged 2 commits into from
Sep 7, 2021
Merged

Nuclear Missile exploit fix #209

merged 2 commits into from
Sep 7, 2021

Conversation

alanblack166
Copy link
Contributor

This commit should fix the Nuclear Missile exploit.

@alanblack166
Nuclear Missile exploit fix
728f5b5 
This commit should fix the Nuclear Missile exploit.
@xezon xezon self-requested a review September 5, 2021 06:32
@xezon
Copy link
Collaborator

xezon commented Sep 6, 2021

alan says "should" be fixed. Meaning we should still verify the fix, no? I can test later.

@alanblack166
Copy link
Contributor Author

Yes, best to test it. It works on my end, but it's always good to double check.

@commy2
Copy link
Collaborator

commy2 commented Sep 6, 2021

Asuming this works, same shoul be added to:
SupW_NeutronMissile and CruiseMissile

@xezon
Copy link
Collaborator

xezon commented Sep 7, 2021

Tested. Fix works.

commy2
commy2 approved these changes Sep 7, 2021
View reviewed changes
Copy link
Collaborator

@commy2 commy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xezon xezon merged commit 86aad93 into main Sep 7, 2021
@xezon xezon deleted the nuke-exploit-fix branch September 7, 2021 18:55
xezon pushed a commit that referenced this pull request Aug 28, 2022
@alanblack166
Nuclear Missile exploit fix (#209)
5deedd9
@xezon xezon added Bug Something is not working right Critical Severity: Minor < Major < Critical < Blocker China Affects China faction labels Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commy2 commy2 commy2 approved these changes

@xezon xezon xezon approved these changes

Assignees
No one assigned
Labels
Bug Something is not working right China Affects China faction Critical Severity: Minor < Major < Critical < Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanblack166 @xezon @commy2