Fix: Helix and Overlord addons are now colored red when affected by Frenzy

[alanblack166]

With these changes, the Helix and Overlord addons will now be properly tinted red when their parent unit is affected by Frenzy.

[commy2]

Does this mean mobile Gattlings now fire faster due to Avenger blue laser?

[alanblack166]

Should not be the case.

[xezon]

I tested all factions. All units look good.

[xezon]

Hmm. Are we sure this negates it correctly?

  WeaponBonus = FRENZY_ONE    DAMAGE 110% ; Granted by a China Generals power
  WeaponBonus = FRENZY_TWO    DAMAGE 120%
  WeaponBonus = FRENZY_THREE  DAMAGE 130%

VS

  WeaponBonus           = FRENZY_ONE DAMAGE 90%
  WeaponBonus           = FRENZY_TWO DAMAGE 80%
  WeaponBonus           = FRENZY_THREE DAMAGE 70%

It may be calculated like so:

1,1 * 0,9 = 0,99 = 99%
1,2 * 0,8 = 0,96 = 96%
1,3 * 0,7 = 0,91 = 91%

Right now we count on it being calculated like so:

(1,1 + 0,9) / 2 = 1,00 = 100%
(1,2 + 0,8) / 2 = 1,00 = 100%
(1,3 + 0,7) / 2 = 1,00 = 100%

But that is not clear (to me).

[alanblack166]

The latter calculation is accurate. We use such means in ROTR for weapons that are not meant to gain any bonuses.

[commy2]

The actual calculation works like this:

total = (bonus_1 - 1) + (bonus_2 - 1) + 1

So

bonus_1 = 110%
bonus_2 = 90%

=> total = 100%

bonus_1 = 110%
bonus_2 = 120%

=> total = 130%

which is, admittedly, counter intuitive.