Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Auto Reload Battery When Idle #1178

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Change: Auto Reload Battery When Idle #1178

merged 1 commit into from
Sep 14, 2022

Conversation

commy2
Copy link
Collaborator

@commy2 commy2 commented Sep 10, 2022

1.04

  • In case the target is destroyed or moved out of range, but the Patriot fired less than four missiles, the next time a target moves into range it will only shoot less than 4 missiles with its first salvo, because the clip is not reloaded until completely empty.

patch:

  • The Patriot will reload the entire clip after being idle for ~2 seconds. (This is also how the Rocket Buggy operates for comparision).

Note: In 1.04, the player has always the option to manually empty the clips by force-firing the ground. I have never seen this used in practice, probably because this issue is rather minor, or because the current mechanics are opaque to the players.

@commy2 commy2 added Design Is a matter of game design Minor Severity: Minor < Major < Critical < Blocker labels Sep 10, 2022
@Stubbjax
Copy link
Collaborator

Very nice. Should this change also be applied to the assist weapons?

@commy2
Copy link
Collaborator Author

commy2 commented Sep 10, 2022

The assist logic should be removed from the game.

@Jundiyy
Copy link
Collaborator

Jundiyy commented Sep 10, 2022

I this this is a good change.
If I'm correct, Auto Loader also does this, I'm not so sure if it is good change for the Battle Master, Auto Loaders are used mainly for Tank vs Stealth and Tank mirrors, in which both match ups are quite evenly matched. Maybe open a new topic and see what others think regarding it?

@xezon
Copy link
Collaborator

xezon commented Sep 13, 2022

Any particular reason 2100 ms was chosen?

@commy2
Copy link
Collaborator Author

commy2 commented Sep 13, 2022

AutoReloadWhenIdle is always ClipReloadTime + 100 (at least 1 frame). See BuggyRocketWeapon or ComancheAntiTankMissileWeapon for examples.
Probably so you can't reload faster by idleing, which would be cheese. Not sure why 1 frame more though. I am blindly trusting what EALA uses.

Copy link
Collaborator

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@xezon xezon merged commit 10b2dec into main Sep 14, 2022
@xezon xezon deleted the auto-reload-patriot branch September 14, 2022 07:18
@xezon xezon added Buff Makes a thing more powerful USA Affects USA faction labels Jan 18, 2023
@commy2 commy2 mentioned this pull request Aug 1, 2023
@xezon xezon added the Controversial Is controversial label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Buff Makes a thing more powerful Controversial Is controversial Design Is a matter of game design Minor Severity: Minor < Major < Critical < Blocker USA Affects USA faction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants