Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emergency Repair Proposal 5, Repair Vehicles In Area Over Time #1067

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

xezon
Copy link
Collaborator

@xezon xezon commented Sep 1, 2022

Implementation of proposal 5 for #707.

After this pull request, the repair effect lingers for 10 seconds (with visible decal). The vehicles are repaired over time instead of in one burst. Upgrading the ability increases how long the effect lasts (to 20 and 30 seconds respectively). Upgrading the ability does not increase the healing speed. The total healing amount only differs due to the time the ability lasts. The radius is increased by +50% (which equals +125% area).

Vehicles can move in and out of the repair area. They are only repaired while inside the area.

New_Emergency_Repair.mp4

Note: this needs translations for anything other than EN and DE.

@xezon xezon added OngoingDiscussion Requires further discussion Design Is a matter of game design labels Sep 1, 2022
@commy2
Copy link
Collaborator

commy2 commented Sep 1, 2022

This is the only change that would make me ever consider chosing ER.

@commy2 commy2 force-pushed the balance-emergency-repair-proposal-5 branch from f08c36e to a4875ce Compare August 1, 2023 14:33
@xezon
Copy link
Collaborator Author

xezon commented Aug 1, 2023

We need to test this on Overlords.

@commy2
Copy link
Collaborator

commy2 commented Aug 1, 2023

Made it also repair buildings. Translation missing from Arabic.

@commy2 commy2 mentioned this pull request Aug 1, 2023
@xezon
Copy link
Collaborator Author

xezon commented Aug 1, 2023

The level 3 Emergency takes 30 seconds to repair an Overlord half.
The Subliminal Messaging (upgraded) takes 25 seconds to repair an Overlord half.

@xezon
Copy link
Collaborator Author

xezon commented Aug 1, 2023

The repair ability for buildings is nice. Makes it more useful, especially for China. But it does not repair much, just this much from 1 health:

shot_20230801_182441_3

Perhaps repair amount should be higher?

@xezon
Copy link
Collaborator Author

xezon commented Aug 1, 2023

The problem of increasing healing amount with this particular implementation could be that units could become quite difficult to kill while inside the affect radius. Right now one Gattling Tank is still enough to damage a Humvee with Repair + Ambulance, but increased Repair amount could change this. On the other hand it is nice that it becomes no wasted ability when there are just a few damaged units at the time of use but there is the expectation of more damage to heal over time.

@xezon
Copy link
Collaborator Author

xezon commented Aug 1, 2023

I found that repairing of structures does not stack. So if ability repairs structure first, then Dozer does not repair, and vice versa. And Dozer repairs structure much faster, perhaps 3 times as fast, so this repair ability is really not great on structures as is.

shot_20230801_184007_4

@commy2
Copy link
Collaborator

commy2 commented Aug 1, 2023

The problem of increasing healing amount with this particular implementation could be that units could become quite difficult to kill while inside the affect radius. Right now one Gattling Tank is still enough to damage a Humvee with Repair + Ambulance, but increased Repair amount could change this. On the other hand it is nice that it becomes no wasted ability when there are just a few damaged units at the time of use but there is the expectation of more damage to heal over time.

It's possible to have one module repair vehicles, another repair buildings, where the one that repairs buildings repairs a bigger amount.

@xezon
Copy link
Collaborator Author

xezon commented Aug 1, 2023

Repair also does not stack on vehicles. Tested with Ambulance and Subliminal Messaging and repair rate of 10.

This means the Repair ability is useless on a blob of units that have an Ambulance or Prop Tower in the mix.

@commy2
Copy link
Collaborator

commy2 commented Aug 1, 2023

Seems to be an engine thing then. In 1.04, ER is completely swallowed by Propaganda Towers: the entire burst is.

@xezon
Copy link
Collaborator Author

xezon commented Aug 1, 2023

Seems to be an engine thing then. In 1.04, ER is completely swallowed by Propaganda Towers: the entire burst is.

That is even more useless then :D

I think this needs a bug report.

@commy2
Copy link
Collaborator

commy2 commented Aug 1, 2023

Ok, doubled repair rate on buildings. Feel free to tune.

@commy2
Copy link
Collaborator

commy2 commented Aug 1, 2023

I think this needs a bug report.

#2186

@xezon
Copy link
Collaborator Author

xezon commented Aug 1, 2023

With fixed stacking I think the effects would be quite nice. However, I do expect problem with Early_Command_EmergencyRepair.

Airforce, Stealth, Nuke and Tank have Rank 1 Emergency Repair. Especially with Airforce this could be problematic, as this could exacerbate problems with strong Humvee Rush (#640).

@commy2
Copy link
Collaborator

commy2 commented Aug 1, 2023

Yeah, could get rid of early version, or distribute it only to faction that need it (SWG?). This would need lots of playtesting though.

@xezon
Copy link
Collaborator Author

xezon commented Aug 1, 2023

On the other hand, in normal circumstances the Command Center will be sold, so perhaps will not make a practical difference in early game.

@xezon xezon added the Minor Severity: Minor < Major < Critical < Blocker label Aug 8, 2023
@commy2 commy2 removed their assignment Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Is a matter of game design Minor Severity: Minor < Major < Critical < Blocker OngoingDiscussion Requires further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants