Laravel 6.x Shift

[restart-tech]

This pull request includes the changes for upgrading to Laravel 6.x. Feel free to commit any additional changes to the shift-51682 branch.

Before merging, you need to:

• Checkout the shift-51682 branch
• Review all pull request comments for additional changes
• Run composer update (if the scripts fail, add --no-scripts)
• Clear any config, route, or view cache
• Thoroughly test your application (no tests?)

If you need help with your upgrade, check out the Human Shifts. You may also join the Shifty Coders Slack workspace to level-up your Laravel skills.

[restart-tech]

❌ Shift could not upgrade the following files since they differed from the default Laravel version. You will need to compare these files against the default Laravel 6 versions and merge any changes:

• app/Http/Controllers/Auth/ResetPasswordController.php
• app/Http/Kernel.php
• resources/lang/en/passwords.php
• resources/lang/en/validation.php

[restart-tech]

⚠️ Laravel 6.x consolidated references to /home as a constant within the RouteServiceProvider. This makes it easier to maintain and change in a single place.

Shift automated this change, but could not upgrade the following files since they differed from the default Laravel version. You should compare these files against the default Laravel 6 versions and merge this change:

• app/Http/Controllers/Auth/LoginController.php
• app/Http/Controllers/Auth/RegisterController.php
• app/Http/Middleware/RedirectIfAuthenticated.php

[restart-tech]

⚠️ Shift upgraded your configuration files by defaulting them and merging your true customizations. These include values which are not changeable through core ENV variables.

You should review this commit for additional customizations or opportunities to use new ENV variables. If you have a lot of customizations, you may undo this commit with git revert 964267bb and make the config file changes manually.

[restart-tech]

ℹ️ Laravel 6 changed the default Redis client from predis to phpredis. You may keep using predis by setting REDIS_CLIENT=predis for your environment.

[restart-tech]

ℹ️ Shift updated your dependencies for Laravel 6. While many of the popular packages are reviewed, you may have to update additional packages in order for your application to be compatible with Laravel 6.

Watch dealing with dependencies for tips on handling any additional package incompatibilities.

[restart-tech]

ℹ️ The Eloquent model's toArray() method will now cast any attributes that implement Illuminate\Contracts\Support\Arrayable to an array. While unlikely to impact your application, this change could effect code which relies upon the previous data type or output.

[restart-tech]

ℹ️ Laravel 6 now requires Carbon 2. While Shift reviewed your application for common breaking changes, you may want to review the Carbon 2 migration notes for additional changes.

[restart-tech]

⚠️ PHPUnit 8 deprecated using assertContains for strings. This assertion now only handles arrays or Traversable objects.

Shift attempted to convert assertions where possible, but detected additional uses of assertContains you should review and, if these arguments are strings, convert them to the new string assertion methods.

• tests/Feature/Groups/GroupCreateTest.php
• tests/Feature/Groups/GroupDeleteTest.php
• tests/Feature/Groups/GroupEditTest.php
• tests/Feature/Groups/GroupHostTest.php
• tests/Feature/Groups/GroupJoinTest.php
• tests/Unit/Events/CoordinatorTests.php
• tests/Unit/NetworkTests.php

[restart-tech]

⚠️ Previous versions of Laravel would bind parameters passed to the URL helper methods as placeholder values even if the names mismatched. In Laravel 6, named parameters not matching placeholders are attached to the query string instead.

Shift detected the following route() and action() calls passing named parameters you should review to ensure they match the route placeholder name.

• app/Http/Controllers/MobifixOraController.php
• app/Http/Controllers/PrintcatOraController.php
• resources/views/networks/partials/add-group-modal.blade.php
• resources/views/partials/notification.blade.php
• resources/views/user/notifications.blade.php

[restart-tech]

ℹ️ Laravel 6 made performance optimizations for integer key types. If you are using a string as your model's primary key, you may set the $keyType property on your model.

/**
 * The "type" of the primary key ID.
 *
 * @var string
 */
protected $keyType = 'string';

[restart-tech]

ℹ️ The mandrill and sparkpost mail drivers, as well as the rackspace storage driver were removed in Laravel 6. If you were using these drivers, you may adopt a community maintained package which provides the driver.

[restart-tech]

ℹ️ Previous versions of Laravel would retry jobs indefinitely. Beginning with Laravel 6, the php artisan queue:work now tries a job one time by default. If you want to force jobs to be tried indefinitely, you may pass the --tries=0 option.

[restart-tech]

🎉 Congratulations, you've made it to the latest LTS version. However, Shift encourages you to keep going to the latest Laravel version. No reason to remain on this older version and acquire technical debt when you're so close...

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
7.1% Duplication