Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cpp_object usertype error #1454

Closed
wants to merge 1 commit into from
Closed

Conversation

likun123687
Copy link

Fix usertype_call_from_c++.cpp cpp_object usertype error

fix usertype_call_from_c++.cpp cpp_object usertype error
@ThePhD ThePhD self-assigned this Jul 18, 2023
@ThePhD ThePhD added this to the Bugs milestone Jul 18, 2023
@ThePhD
Copy link
Owner

ThePhD commented Jul 18, 2023

Wait. The rest of the code still uses e.g. lua["test"], though. This would cause things to break...?

I'll adjust it locally and re-up this though, I guess.

ThePhD added a commit that referenced this pull request Jul 18, 2023
…ecks.

— Addresses #1454
— Remove zero-based check for certain versioning macros for Lua (need others?)
@ThePhD
Copy link
Owner

ThePhD commented Jul 18, 2023

This is fixed properly now, thanks.

@ThePhD ThePhD closed this Jul 18, 2023
phwissmann pushed a commit to phwissmann/sol2 that referenced this pull request Mar 4, 2024
…ecks.

— Addresses ThePhD#1454
— Remove zero-based check for certain versioning macros for Lua (need others?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants