Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4650 ThePay\ApiClient\Http replaced by PSR standarts #49

Merged
merged 1 commit into from
Jul 11, 2023
Merged

4650 ThePay\ApiClient\Http replaced by PSR standarts #49

merged 1 commit into from
Jul 11, 2023

Conversation

Triplkrypl
Copy link
Member

@Triplkrypl Triplkrypl added the enhancement New feature or request label Jun 30, 2023
@Triplkrypl Triplkrypl requested a review from joseftraxler June 30, 2023 14:43
@Triplkrypl Triplkrypl self-assigned this Jun 30, 2023
joseftraxler
joseftraxler reviewed Jul 3, 2023
View reviewed changes
.github/README.md Outdated Show resolved Hide resolved
@Triplkrypl Triplkrypl requested a review from joseftraxler July 3, 2023 13:14
joseftraxler
joseftraxler requested changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@joseftraxler joseftraxler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job👍. Have a look at my notes, please.

.github/README.md Outdated Show resolved Hide resolved
.github/README.md Outdated Show resolved Hide resolved
.github/README.md Outdated Show resolved Hide resolved
composer.json Show resolved Hide resolved
composer.json Show resolved Hide resolved
src/Service/ApiService.php Show resolved Hide resolved
src/TheClient.php Show resolved Hide resolved
src/TheClient.php Outdated Show resolved Hide resolved
.github/README.md Show resolved Hide resolved
@Triplkrypl Triplkrypl force-pushed the v2.x-4650-http-psr branch from 024f0f1 to c1ce035 Compare July 10, 2023 17:19
@Triplkrypl Triplkrypl requested a review from joseftraxler July 10, 2023 17:29
joseftraxler
joseftraxler reviewed Jul 11, 2023
View reviewed changes
doc/notifications.md Outdated Show resolved Hide resolved
joseftraxler
joseftraxler requested changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@joseftraxler joseftraxler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great 👍.
Just have a look on my notes please. I think we don't need to duplicate making TheClient instance to every document, but just add reference link to specific section of README.md.

@Triplkrypl Triplkrypl force-pushed the v2.x-4650-http-psr branch from c1ce035 to a1bfb37 Compare July 11, 2023 11:31
@Triplkrypl Triplkrypl force-pushed the v2.x-4650-http-psr branch from a1bfb37 to 8f82beb Compare July 11, 2023 11:34
@Triplkrypl Triplkrypl requested a review from joseftraxler July 11, 2023 11:37
joseftraxler
joseftraxler approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@joseftraxler joseftraxler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Triplkrypl Triplkrypl merged commit 3e25a1e into v2.x Jul 11, 2023
@Triplkrypl Triplkrypl deleted the v2.x-4650-http-psr branch July 11, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseftraxler joseftraxler joseftraxler approved these changes

Assignees

@Triplkrypl Triplkrypl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Triplkrypl @joseftraxler