Merge pull request #27 from ThePay/hotfix-4213-header-case-sensitivity

Hotfix 4213 header case sensitivity

src/Http/HttpResponse.php

@@ -98,6 +98,21 @@ public function getHeaders()
         return $this->headers;
     }
 
+    /**
+     * @param non-empty-string $key
+     * @return string|null
+     */
+    public function getHeader($key)
+    {
+        foreach ((array) $this->headers as $headerKey => $header) {
+            if (strtolower($headerKey) === strtolower($key)) {
+                return $header;
+            }
+        }
+
+        return null;
+    }
+
     /**
      * @return string|null
      */

src/Service/ApiService.php

@@ -129,9 +129,7 @@ public function getAccountTransactionHistory(TransactionFilter $filter, $page =
             throw $this->buildException($url, $response);
         }
 
-        $headers = $response->getHeaders();
-
-        return new TransactionCollection(Json::decode($response->getBody(), true), $page, $limit, (int) $headers['X-Total-Count']);
+        return new TransactionCollection(Json::decode($response->getBody(), true), $page, $limit, (int) $response->getHeader('X-Total-Count'));
     }
 
     /**
@@ -203,9 +201,7 @@ public function getPayments(PaymentsFilter $filter, $page = 1, $limit = 25)
             throw $this->buildException($url, $response);
         }
 
-        $headers = $response->getHeaders();
-
-        return new PaymentCollection($response->getBody(), $page, $limit, (int) $headers['X-Total-Count']);
+        return new PaymentCollection($response->getBody(), $page, $limit, (int) $response->getHeader('X-Total-Count'));
     }
 
     /**

src/TheClient.php

@@ -42,7 +42,7 @@
 class TheClient
 {
     /** @var string */
-    const VERSION = '1.4.2';
+    const VERSION = '1.4.3';
 
     /** @var TheConfig */
     private $config;

tests/Http/HttpResponseTest.php

@@ -0,0 +1,42 @@
+<?php
+
+namespace ThePay\ApiClient\Tests\Http;
+
+use PHPUnit\Framework\TestCase;
+use ThePay\ApiClient\Http\HttpResponse;
+
+/**
+ * @covers \ThePay\ApiClient\Http\HttpResponse
+ */
+final class HttpResponseTest extends TestCase
+{
+    /**
+     * @dataProvider dataProviderGetHeader
+     *
+     * @param string|null $expectedValue
+     * @param non-empty-string $headerKey
+     * @param array<string, string>|null $headers
+     *
+     * @return void
+     */
+    public function testGetHeader($expectedValue, $headerKey, array $headers = null)
+    {
+        $response = new HttpResponse(null, null, '', $headers);
+        self::assertSame($expectedValue, $response->getHeader($headerKey));
+    }
+
+    /**
+     * @return non-empty-array<array{string|null, non-empty-string, array<string, string>|null}>
+     */
+    public function dataProviderGetHeader()
+    {
+        return array(
+            array(null, 'no-headers', null),
+            array(null, 'empty-headers', array()),
+            array(null, 'key-not-found', array('another-key' => 'another-value')),
+            array('value-for-lower-key', 'lower-key', array('Lower-Key' => 'value-for-lower-key')),
+            array('value-for-upper-key', 'UPPER-KEY', array('Upper-Key' => 'value-for-upper-key')),
+            array('value-for-same-key', 'same-key', array('same-key' => 'value-for-same-key')),
+        );
+    }
+}