Sync CI workflows with circulation #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathangreen
force-pushed
the
feature/sync-with-circulation
branch
from
34d8131
to
218ef42
Compare
tdilauro
approved these changes
Jan 25, 2022
| run: | | ||
| curl -sSL ${{ env.POETRY_URL }} | python - | ||
| echo "$HOME/.local/bin" >> $GITHUB_PATH | ||
| uses: ThePalaceProject/circulation/.github/actions/poetry@main |
There was a problem hiding this comment.
Not urgent, but should we eventually move this to ci-scripts since it is shared? And maybe rename ci-scripts to ci-shared?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrate the recent CI changes in the circulation repo into the workflows we are using in library-registry.
Motivation and Context
Motivated as an effort to keep the development process between the two repos aligned as much as possible.
The first commit is the manual changes, the other commits are just automated formatting changes that come in with the additional linters added by precommit.
How Has This Been Tested?
These changes are mostly to CI processes, so CI passing should be a good test that it is working.
Checklist: