Prevent creation of admins when username unknown #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While testing the registry I noticed that logging in using a username that is not in the database causes a record to be created with an empty password hash. Attempting to log in with the same credentials then results in a 500 since attempts to validate a user with no password hash breaks the authentication.
This PR ensures that a new admin user is created only when there are no admins in the database (ie on first access). After that logging in with a random user and password does not result in a new admin user being added to the database.
It also includes an alembic migration to remove any admin users with empty or null password fields.
Motivation and Context
Notion
How Has This Been Tested?
Manually tested and unit test verifies fix.
Checklist