Build arm version of images #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathangreen
commented
Feb 22, 2023
| && apk add --no-cache --virtual .cert-deps openssl \ | ||
| && wget -O /tmp/nginx_signing.rsa.pub https://nginx.org/keys/nginx_signing.rsa.pub \ | ||
| && if [ "$(openssl rsa -pubin -in /tmp/nginx_signing.rsa.pub -text -noout | openssl sha512 -r)" = "$KEY_SHA512" ]; then \ | ||
| && if echo "$KEY_SHA512 */tmp/nginx_signing.rsa.pub" | sha512sum -c -; then \ |
There was a problem hiding this comment.
These changes came directly from the upstream docker file:
https://github.com/nginxinc/docker-nginx/blob/master/mainline/alpine/Dockerfile
I needed to update the dependencies to get the arm version building.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are building arm versions of our docker images for CM and VLC, we should probably build an arm version of the registry image as well for all our M1 users, as well as if we ever decide to try the AWS ARM images.
Motivation and Context
Similar to the changes in ThePalaceProject/virtual-library-card#232
How Has This Been Tested?
Running CI
Checklist