Skip to content

Commit

Permalink
allows role=combobox on button and input type=button
Browse files Browse the repository at this point in the history
This PR addresses [ARIA in HTML](w3c/html-aria#396) being updated to allow the `combobox` role on these elements, and fix an oversight where `role=checkbox` should have been allowed on `input type=button` to match the same allowance on the `button` element.
  • Loading branch information
scottaohara authored Jan 15, 2022
1 parent 922d989 commit 1128ff2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions aria-usage.js
Original file line number Diff line number Diff line change
Expand Up @@ -864,7 +864,7 @@ var objElementRules = {
"button": {
"nodeName": "button",
"nativeRole": "button",
"allowedRoles": ["checkbox", "link", "menuitem", "menuitemcheckbox", "menuitemradio", "option", "radio", "switch", "tab"]
"allowedRoles": ["checkbox", "combobox", "link", "menuitem", "menuitemcheckbox", "menuitemradio", "option", "radio", "switch", "tab"]
},
"canvas": {
"nodeName": "canvas",
Expand Down Expand Up @@ -1069,7 +1069,7 @@ var objElementRules = {
"input-button": {
"nodeName": "input",
"nativeRole": "button",
"allowedRoles": ["link", "menuitem", "menuitemcheckbox", "menuitemradio", "option", "radio", "switch", "tab"]
"allowedRoles": ["checkbox", "combobox", "link", "menuitem", "menuitemcheckbox", "menuitemradio", "option", "radio", "switch", "tab"]
},
"input-checkbox": {
"nodeName": "input",
Expand Down

0 comments on commit 1128ff2

Please sign in to comment.