Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate to pt-BR #351

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

igorcasmarques
Copy link
Contributor

  • Added pt-BR.json to src/views/translations and adjusted preferences.html and about.html accordingly
  • Fixed 2 typos in en.json
  • Added comments in preferences.html of two variables not currently translateable (feel free to reject these as I can open issues about them)

I also noticed CopyPaste only translates the pass-fail statements; everything else stays in English. Should I open an issue about this?

ferllings
ferllings previously approved these changes Aug 19, 2024
@ferllings
Copy link
Member

ferllings commented Aug 19, 2024

@igorcasmarques could you remove the yarn.lock file from the PR?

@ferllings
Copy link
Member

@igorcasmarques Any updates?

@igorcasmarques
Copy link
Contributor Author

Oops, somehow I missed this. I've removed yarn.lock from the PR. Let me know if you need anything else.

@ferllings
Copy link
Member

Hi @igorcasmarques I still can't merge your PR: you need to reset the file to its original state, not remove it.

@ferllings
Copy link
Member

@igorcasmarques Sorry to push you, but I would like to release before end of week

@igorcasmarques
Copy link
Contributor Author

Thank you for your patience, @ferllings.

I use git for personal projects but this is my first time contributing to a public project. I hope I got this right now, but let me know if I haven't. I've squashed the commits as well to avoid clutter.

@ferllings ferllings merged commit f334593 into ThePacielloGroup:main Sep 4, 2024
@ferllings
Copy link
Member

@igorcasmarques All good now. Thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants