This repository has been archived by the owner on Sep 22, 2023. It is now read-only.
fix font issue #19
Open
fix font issue #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: public/index.html modified: src/App.css modified: src/App.jsx
modified: src/App.jsx
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to fix the issue #18
Seems the Chinese web font cause this problem so I edited the font file itself (resized the characters).
The Japanese font (ユールカ Std) is preferred in the project style sheet. But when we inputting Chinese, if there are no Chinese characters in the Japanese font, it will fallback to use alternative Chinese font (ShangShouFangTangTi). The Chinese font now using doesn't belong to the same font-family as the Japanese font. Although there have been many Chinese versions of Fontworks fonts made by Founder Font, but there are no Chinese versions of the fonts used here. So there is no choice but to edit the font file.
renderings: