Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermediate HTML and CSS Course-Advanced Selectors-add note #29241 #29277

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Intermediate HTML and CSS Course-Advanced Selectors-add note #29241 #29277

merged 3 commits into from
Jan 6, 2025

Conversation

danieletie
Copy link
Contributor

Because

The purpose of this PR is to add a note for clarity to the Advanced Selectors lesson in the Intermediate HTML and CSS course in the Full Stack JS Path

This PR

  • Add a note to stop users from doing the test your skills at the bottom of the link prematurely (i.e before they encounter topics that are treated in the test your skills)
  • Add link to the test your skills exercise at the bottom of the lesson assignment

Issue

Closes #29241

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@danieletie
Update advanced selectors lesson TheOdinProject#29241
24f47f7 
- add note to 'MDN article on combinators' link not to do test your skill
  at bottom of linked MDN article for selectors
- add assignment that links to test your skills section of MDN article
  to practice lesson on selectors
@danieletie
Update advanced selectors lesson TheOdinProject#29241
e398a4a 
- add note to 'MDN article on combinators' link not to do test your skill
  at bottom of linked MDN article for selectors
- add assignment that links to test your skills section of MDN article
  to practice lesson on selectors
@github-actions github-actions bot added the Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course label Jan 4, 2025
@danieletie
Correct spelling error in newly added assignment
e49100b 
- correct the spelling of assesment to assessment.
KevinMulhern
KevinMulhern approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danieletie

@KevinMulhern KevinMulhern merged commit b4d3224 into TheOdinProject:main Jan 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinMulhern KevinMulhern KevinMulhern approved these changes

Assignees
No one assigned
Labels
Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Advanced Selectors: Add note not to do the test Skills in linked MDN article
2 participants
@danieletie @KevinMulhern