Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importmap: Fix fenced code block languages and linting #29070

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

MaoShizhong
Copy link
Contributor

@MaoShizhong MaoShizhong commented Nov 10, 2024

Because

There were several linting issues that could be autofixed, and one code block that contained two different languages would've flagged errors if it wasn't split into the appropriate separate blocks.

This PR

  • Splits a ruby code block into ruby and erb, which would be more appropriate
  • Fixes fenced code block language names to be the lowercase full names as per the TOP006 lint rule
  • Runs the autofixer to address remaining lint errors

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

Use all lowercase full names as per the TOP006 lint rule
@github-actions github-actions bot added the Content: Ruby on Rails Involves the Ruby on Rails course label Nov 10, 2024
Copy link
Member

@rlmoser99 rlmoser99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to update this lesson! 🚀

@rlmoser99 rlmoser99 merged commit 4004f98 into TheOdinProject:main Nov 10, 2024
3 checks passed
@MaoShizhong MaoShizhong deleted the ruby-importmap-linting branch November 10, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Ruby on Rails Involves the Ruby on Rails course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants