Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit Messages: Fix punctuation #29060

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

Ghost-from-V01d
Copy link
Contributor

@Ghost-from-V01d Ghost-from-V01d commented Nov 7, 2024

Because

This pull request fixes inconsistencies in punctuation within the commit message guidelines.
Correcting these minor punctuation issues makes the guidelines clearer and more standardized.

This PR

  • Add two missing periods to maintain consistent punctuation in the lesson text.
  • Clarify the guideline that subject lines in commit messages should not end with a period.

Issue

Closes #XXXXX

Additional Information

N/A

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

In Git commit message guidelines, the subject line shouldn't end with a period (".").

Added two missing periods where needed to maintain consistency.
@github-actions github-actions bot added the Content: Git Involves Git content label Nov 7, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up.

@MaoShizhong MaoShizhong merged commit 93b8ba4 into TheOdinProject:main Nov 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Git Involves Git content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants