Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Comments in code #28698

Merged
merged 1 commit into from
Aug 25, 2024
Merged

Fix: Comments in code #28698

merged 1 commit into from
Aug 25, 2024

Conversation

XAJX179
Copy link
Contributor

@XAJX179 XAJX179 commented Aug 25, 2024

Because

Comments in code were not commented out.

This PR

  • adds comment syntax.
  • splits the code so the commented result matches.

Issue

nil

Additional Information

nil

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Ruby Involves the Ruby course label Aug 25, 2024
Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @XAJX179

@KevinMulhern KevinMulhern merged commit 11ceb20 into TheOdinProject:main Aug 25, 2024
2 of 3 checks passed
@XAJX179
Copy link
Contributor Author

XAJX179 commented Aug 25, 2024

Thanks @XAJX179

Thanks for your time too!

should we reopen this to fix the markdownlint errors?

@MaoShizhong
Copy link
Contributor

@XAJX179 You're welcome to open a new PR addressing the code block/blank line lint errors. If you sync your fork's main first, you'll update your markdownlint configuration which disables the "Link fragment must be valid" rule, as it clashes with how we handle link fragments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Ruby Involves the Ruby course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants