Installing Ruby: Update installing_ruby.md #28624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 1.3.0 of rbenv has a feature change where rbenv init comes from the bin directory instead of right in the ~/.rbenv directory and now modifies shell initialization files instead of only printing instructions. The lesson needs to now either specify whether to use an older version, or if using the latest version, the terminal must be refreshed after this step. I am fresh out of Foundations and unsure how this change may affect any subsequent lessons in the course.
beneficial-radish
changed the title
|
There is a linting issue that needs fixing if you don't mind. You just need to add a blank line below the code block. |
Absolutely! Is it fine to do this directly from GitHub? |
A blank line was needed under the code block. Simplified instructions on closing and opening the terminal.
|
Yeah it should be @beneficial-radish |
KevinMulhern
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 1.3.0 of rbenv has a feature change where rbenv init comes from the bin directory instead of right in the ~/.rbenv directory and now modifies shell initialization files instead of only printing instructions.
The lesson now needs a new filepath for init and instructions for the terminal to be refreshed in order for the next steps in installation to work.
Because
The most recent update to rbenv requires updates to installation instructions.
This PR
Issue
Closes #28625 28625
Additional Information
https://discordapp.com/channels/505093832157691914/543074220691947531/1272810885999628288
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection